-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OUDS] Docs: empty pages content #2612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
julien-deramond
force-pushed
the
ouds/main-jd-empty-pages
branch
from
July 10, 2024 12:32
0ba4b69
to
2a92315
Compare
julien-deramond
commented
Jul 10, 2024
julien-deramond
force-pushed
the
ouds/main-jd-empty-pages
branch
from
July 10, 2024 12:53
5d8750b
to
ead9f41
Compare
16 tasks
julien-deramond
force-pushed
the
ouds/main-jd-empty-pages
branch
from
July 12, 2024 11:12
0ef0ff2
to
a32dd1a
Compare
julien-deramond
force-pushed
the
ouds/main-jd-empty-pages
branch
from
July 12, 2024 11:19
a32dd1a
to
24f5b89
Compare
vprothais
approved these changes
Jul 12, 2024
louismaximepiton
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR finalizes the clean-up of our OUDS Web main branch before starting the development:
Please be aware that when some resources were not used anymore, they were dropped from the repository as well.
OUDS Web and Bootstrap versions
Boosted and Bootstrap were using the exact same versions at the same time. Now we have to deal with different versions, and so, some Hugo params must be split:
bootstrap_docs_version
parameter set to5.3
bootstrap_current_version
parameter set to5.3.3
System of URLs
This PR fixes the URLs issues and configuration and works when:
npm run start
npm run docs
, then runphp -S localhost:8008
in_site
directorynpm run release
,mv _site/ouds-web /tmp
,git checkout gh-pages
,rm -rf ouds-web/*
,mv /tmp/ouds-web/* ouds-web/
, then runphp -S localhost:8008
Instead of adding a
/ouds-web
everywhere in the code like tried in https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/pull/2614/files, amodify-site.sh
script does it only when we build the documentation targettinggh-pages
.It allows running the documentation locally and via Netlify as usual, and we'll only need to drop the usage of this script whenever OUDS Web will replace Boosted.
Please note that there are some edge cases that don't work for now until the new DNS is correctly set up, but should be automatically handled in a near future:
After the merge
modify-docs.sh
script work on Windows tooReferenceError: boosted is not defined
, and handle the JS part correctlyStorybook
The following URLs should work:
npm run start
: https://localhost:9001/storybookgh-pages
: https://orange-opensource.github.io/orange-Boosted-Bootstrap/ouds-web/storybook